[table service] add default port to service hosts#1778
Merged
Conversation
*Motivation* Currently we have to add `4181` in the service uri in order to make it work. Ideally it would be great that the system can fill the default port if port is missing. *Changes* add default port when parsing `ServiceURI`
eolivelli
approved these changes
Nov 1, 2018
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
Okay.
Do you need a similar fix on python client?
Member
Author
yes I will do it in a subsequent change. |
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
Nov 1, 2018
*Motivation* Similar as apache#1778, add default port to service hosts if port is missing. *Changes* add default port to service hosts if they miss ports Related Issue: apache#1778
Member
Author
|
run integration tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Currently we have to add
4181in the service uri in order to make it work.Ideally it would be great that the system can fill the default port if port is missing.
Changes
add default port when parsing
ServiceURI