Skip to content

[release] add bkctl package to release scripts#1907

Merged
sijie merged 4 commits intoapache:masterfrom
sijie:include_bkctl_package
Jan 22, 2019
Merged

[release] add bkctl package to release scripts#1907
sijie merged 4 commits intoapache:masterfrom
sijie:include_bkctl_package

Conversation

@sijie
Copy link
Member

@sijie sijie commented Jan 21, 2019

Descriptions of the changes in this PR:

Motivation

starting from bookkeeper 4.9.0, a separate tool package bkctl is released.

Modifications

add bkctl into release scripts


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

---

*Motivation*

starting from bookkeeper 4.9.0, a separate tool package `bkctl` is released.

*Modifications*

add bkctl into release scripts
@sijie sijie added this to the 4.9.0 milestone Jan 21, 2019
@sijie sijie self-assigned this Jan 21, 2019
sijie added 3 commits January 21, 2019 14:39
---

*Motivation*

when creating branch-4.9, maven release plugin doesn't bump the version for stream modules.

*Modifications*

run `mvn versions:set` to manually fix the version for all modules
@sijie
Copy link
Member Author

sijie commented Jan 21, 2019

rebuild java11

@sijie sijie modified the milestones: 4.9.0, 4.10.0 Jan 22, 2019
@sijie sijie merged commit 5b737b0 into apache:master Jan 22, 2019
@sijie sijie deleted the include_bkctl_package branch January 22, 2019 02:48
sijie added a commit that referenced this pull request Jan 27, 2019
Descriptions of the changes in this PR:


*Motivation*

starting from bookkeeper 4.9.0, a separate tool package `bkctl` is released.

*Modifications*

add bkctl into release scripts




Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #1907 from sijie/include_bkctl_package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants