Issue 2023: change cached thread pool to fixed thread pool#2024
Merged
sijie merged 2 commits intoapache:masterfrom Apr 2, 2019
Merged
Issue 2023: change cached thread pool to fixed thread pool#2024sijie merged 2 commits intoapache:masterfrom
sijie merged 2 commits intoapache:masterfrom
Conversation
bd2019us
changed the title
sijie
approved these changes
Apr 1, 2019
Member
|
can you check the error |
Contributor
|
Please fix compilation issue. |
Contributor
Author
|
Hi, thanks for your quick reply. The compilation error is due to a typo and fixed. |
eolivelli
approved these changes
Apr 2, 2019
Member
|
run bookkeeper-server bookie tests |
Contributor
Author
|
retest please, the code change should not cause any failure. |
Member
sijie
pushed a commit
that referenced
this pull request
Apr 2, 2019
Descriptions of the changes in this PR: change newCachedThreadPool() to newFixedThreadPool(int) ### Motivation newFixedThreadPool(int) can be freely configured with the total number of threads, while cached thread pool may cause OutOfMemoryError when there are too many threads need to created. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #2024 from bd2019us/patch, closes #2023 (cherry picked from commit 0988e12) Signed-off-by: Sijie Guo <sijie@apache.org>
Contributor
Author
|
Ok, Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
change newCachedThreadPool() to newFixedThreadPool(int)
Motivation
newFixedThreadPool(int) can be freely configured with the total number of threads, while cached thread pool may cause OutOfMemoryError when there are too many threads need to created.