Added zookeeper host configuration. Closes #1960#2081
Merged
sijie merged 3 commits intoapache:masterfrom Jun 21, 2019
hugomiguelabreu:master
Merged
Added zookeeper host configuration. Closes #1960#2081sijie merged 3 commits intoapache:masterfrom hugomiguelabreu:master
sijie merged 3 commits intoapache:masterfrom
hugomiguelabreu:master
Conversation
eolivelli
requested changes
May 3, 2019
|
|
||
| final int zkPort = Integer.parseInt(args[0]); | ||
| final String zkHost = args[0]; | ||
| final int zkPort = Integer.parseInt(args[1]); |
Contributor
There was a problem hiding this comment.
Can we make it compatible with only version ?
Just handle the case in which you have only one parameter
sijie
approved these changes
May 5, 2019
Member
|
run integration tests |
Member
|
@hugomiguelabreu can you rebase this change to latest master? |
Contributor
Author
Yes. I rebased the feature without any conflicts. 😄 |
Contributor
Author
|
run integration tests |
Member
|
@hugomiguelabreu can you rebased this to latest apache master? it seems that this pull request shows additional 22 commits. |
Contributor
Author
Forgot to merge into the master, only rebased the branch and pushed. Thanks for the heads up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Added host IP binding to sandbox.
Motivation
Allowing running the sandbox inside guest machines and be accessible by all system (including other guest machines). When binding 127.0.0.1 other guest machines will experience an error. By allowing to bind the correct IP the namespace will be available and correctly configured for other hosts.
Changes
Added a new argument to the dlog tool allowing to define the host IP to bind ZooKeeper and DistributedLog namespace.
Master Issue: #1960