Skip to content

Added zookeeper host configuration. Closes #1960#2081

Merged
sijie merged 3 commits intoapache:masterfrom
hugomiguelabreu:master
Jun 21, 2019
Merged

Added zookeeper host configuration. Closes #1960#2081
sijie merged 3 commits intoapache:masterfrom
hugomiguelabreu:master

Conversation

@hugomiguelabreu
Copy link
Contributor

@hugomiguelabreu hugomiguelabreu commented May 3, 2019

Descriptions of the changes in this PR:
Added host IP binding to sandbox.

Motivation

Allowing running the sandbox inside guest machines and be accessible by all system (including other guest machines). When binding 127.0.0.1 other guest machines will experience an error. By allowing to bind the correct IP the namespace will be available and correctly configured for other hosts.

Changes

Added a new argument to the dlog tool allowing to define the host IP to bind ZooKeeper and DistributedLog namespace.

Master Issue: #1960


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java11]: skip build on java11. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome


final int zkPort = Integer.parseInt(args[0]);
final String zkHost = args[0];
final int zkPort = Integer.parseInt(args[1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it compatible with only version ?
Just handle the case in which you have only one parameter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 😄

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@sijie
Copy link
Member

sijie commented May 6, 2019

run integration tests

@sijie
Copy link
Member

sijie commented Jun 7, 2019

@hugomiguelabreu can you rebase this change to latest master?

@hugomiguelabreu
Copy link
Contributor Author

hugomiguelabreu commented Jun 8, 2019

@hugomiguelabreu can you rebase this change to latest master?

Yes. I rebased the feature without any conflicts. 😄

@hugomiguelabreu
Copy link
Contributor Author

run integration tests

@sijie
Copy link
Member

sijie commented Jun 13, 2019

@hugomiguelabreu can you rebased this to latest apache master? it seems that this pull request shows additional 22 commits.

@hugomiguelabreu
Copy link
Contributor Author

@hugomiguelabreu can you rebased this to latest apache master? it seems that this pull request shows additional 22 commits.

Forgot to merge into the master, only rebased the branch and pushed. Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants