Issue 1927: fix NoNodeException in LocalBookeeper

[zhaohaidao]

Motivation

It addresses #1927 where it provides a conf check at the beginning of startLocalBookiesInternal function.

Changes

• Add a conf check at the beginning of startLocalBookiesInternal function where non-default zkLedgersRootPath is not allowed.

cc @sijie

[zhaohaidao]

Failed replication tests finished with timeout in my laptop(macOS).
It seems that it blocked at test env setup step according the test log.
My test command is as followed.
mvn clean install -DskipTests; mvn -pl bookkeeper-server clean test -Dtest=BookieAutoRecoveryTest#testEmptyLedgerLosesQuorumEventually

Did I execute the right command ? Or I missed something. The test log is attached as followed. Thanks

org.apache.bookkeeper.replication.BookieAutoRecoveryTest-output.txt

[sijie]

run bookkeeper-server replication tests

[zhaohaidao]

Looks like my commit affects case-BookieAutoRecoveryTest#testEmptyLedgerLosesQuorumEventually.
However, this case failed with timeout in my laptop(macOS). Should I do some preparation for test in macOS?

Failed replication tests finished with timeout in my laptop(macOS).
It seems that it blocked at test env setup step according the test log.
My test command is as followed.
mvn clean install -DskipTests; mvn -pl bookkeeper-server clean test -Dtest=BookieAutoRecoveryTest#testEmptyLedgerLosesQuorumEventually

Did I execute the right command ? Or I missed something. The test log is attached as followed. Thanks

org.apache.bookkeeper.replication.BookieAutoRecoveryTest-output.txt

[ivankelly]

This doesn't address #1927. The problem in #1927 is that if you have something like /streaming/bookkeeper/ledgers as your root path, localbookie will fail to start. With this fix, it still fails to start. To address the issue, you need to create the path on boot.

[zhaohaidao]

@ivankelly Thanks for your advice.
My fix logic is that it is simpler to constrain the input range than dealing with arbitrary input.
Although this fix will still fail with /streaming/bookkeeper/ledgers as the root path, the error message means it is an illegal parameter error rather than a runtime error like NoNodeException.
Then if users see the error message, they will update their zkLedgerRootPath.

[ivankelly]

@zhaohaidao the fix to permit the paths is one line, using ZkUtils#createFullPathOptimistic

[zhaohaidao]

@ivankelly Thanks for your reminder. I submitted a fix as per your suggestion. Please have a look at it.

[sijie]

run bookkeeper-server replication tests

[sijie]

@eolivelli can you please take a look at this PR again?

[sijie]

ping @eolivelli