Move common placementpolicy components to TopologyAwareEnsemblePlacementPolicy.#2089
Merged
reddycharan merged 1 commit intoapache:masterfrom May 10, 2019
Merged
Conversation
…entPolicy. - Moving components/methods which are common in nature with respect to placementpolicy from RackawareEnsemblePlacementPolicyImpl to TopologyAwareEnsemblePlacementPolicy, so that any new placementpolicy implementation can extend TopologyAwareEnsemblePlacementPolicy and reuse those common components/generic. - This change has no functionality change, it is just reorganizing code.
Contributor
Author
|
run integration tests |
eolivelli
approved these changes
May 9, 2019
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Assuming it is only a refactor aa you stated on the description
+1
Contributor
Author
|
@eolivelli Thanks for the quick response, yes it is just refactoring, no change in the code/logic. |
sijie
approved these changes
May 10, 2019
reddycharan
added a commit
to reddycharan/bookkeeper
that referenced
this pull request
May 11, 2019
…entPolicy. - Moving components/methods which are common in nature with respect to placementpolicy from RackawareEnsemblePlacementPolicyImpl to TopologyAwareEnsemblePlacementPolicy, so that any new placementpolicy implementation can extend TopologyAwareEnsemblePlacementPolicy and reuse those common components/generic. - Change signature of methods of RackChangeNotifier interface. - Delete duplicate methods in RackawareEnsemblePlacementPolicyImpl and TopologyAwareEnsemblePlacementPolicy (missed removing them in apache#2089) - Created separate class for BookieNode - This change has no functionality change, it is just reorganizing code.
reddycharan
added a commit
to reddycharan/bookkeeper
that referenced
this pull request
May 11, 2019
…entPolicy. - Moving components/methods which are common in nature with respect to placementpolicy from RackawareEnsemblePlacementPolicyImpl to TopologyAwareEnsemblePlacementPolicy, so that any new placementpolicy implementation can extend TopologyAwareEnsemblePlacementPolicy and reuse those common components/generic. - Change signature of methods of RackChangeNotifier interface. - Delete duplicate methods in RackawareEnsemblePlacementPolicyImpl and TopologyAwareEnsemblePlacementPolicy (missed removing them in apache#2089) - Created separate class for BookieNode - This change has no functionality change, it is just reorganizing code.
reddycharan
added a commit
that referenced
this pull request
May 13, 2019
…entPolicy. Descriptions of the changes in this PR: - Moving components/methods which are common in nature with respect to placementpolicy from RackawareEnsemblePlacementPolicyImpl to TopologyAwareEnsemblePlacementPolicy, so that any new placementpolicy implementation can extend TopologyAwareEnsemblePlacementPolicy and reuse those common components/generic. - Change signature of methods of RackChangeNotifier interface. - Delete duplicate methods in RackawareEnsemblePlacementPolicyImpl and TopologyAwareEnsemblePlacementPolicy (missed removing them in #2089) - Created separate class for BookieNode - This change has no functionality change, it is just reorganizing code. Reviewers: Sijie Guo <sijie@apache.org>, Venkateswararao Jujjuri (JV) <None> This closes #2092 from reddycharan/placementpolicyrefactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
placementpolicy from RackawareEnsemblePlacementPolicyImpl to
TopologyAwareEnsemblePlacementPolicy, so that any new placementpolicy
implementation can extend TopologyAwareEnsemblePlacementPolicy and reuse
those common components/generic.