Implement a method to get all the Bookies#2117
Merged
eolivelli merged 3 commits intoapache:masterfrom Jul 12, 2019
Merged
Conversation
mino181295
changed the title
eolivelli
requested changes
Jun 27, 2019
Contributor
|
Please add tests and check CI failures |
Contributor
|
Looks fine to me and it really doesn't intercept what we are doing. I guess tests are needed |
eolivelli
requested changes
Jul 4, 2019
| Code.NONODE.intValue(), null, null); | ||
|
|
||
| try { | ||
| result(zkRegistrationClient.getReadOnlyBookies()); |
| private final String cookiePath; | ||
| // registration paths | ||
| protected final String bookieRegistrationPath; | ||
| protected final String bookieFaultyRegistrationPath; |
Contributor
There was a problem hiding this comment.
This variable seems useless
| .apply(same(shell.bkConf), same(mockListBookiesFlags)); | ||
| verify(mockListBookiesFlags, times(1)).readonly(true); | ||
| verify(mockListBookiesFlags, times(1)).readwrite(false); | ||
| verify(mockListBookiesFlags, times(1)).all(true); |
Contributor
There was a problem hiding this comment.
Is this test passing? I would expect 'false' here
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieShellTest.java
Show resolved
Hide resolved
eolivelli
approved these changes
Jul 11, 2019
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Looks good to me
@jvrao @sijie @reddycharan can you take a look?
sijie
approved these changes
Jul 12, 2019
Contributor
|
@mino181295 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I'm adding a
BokKeeperAdmin#getAllBookiesto retrive all the bookies (cookie) retriving them from theRegistrationClientThis is still a work in progress, I'm adding some tests in the next commit.