Fix batch read data in cache does not take effect#2231
Merged
eolivelli merged 1 commit intoapache:masterfrom Apr 13, 2020
Merged
Fix batch read data in cache does not take effect#2231eolivelli merged 1 commit intoapache:masterfrom
eolivelli merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Hi. We should also add a test case to demonstrate that the fix works and in order to prevent regressions in the future. Thank you for contributing your fix |
Contributor
Author
|
HI.
Problems I found while testing pulsar consumption backtrace,
When reading historical data, you need to pull to disk. In theory, it should be batch pull, but from the phenomenon point of view, it does not. It is used in 4.9.2
Set -1 to firstEntryId and let it increment
------------------ 原始邮件 ------------------
发件人: "Enrico Olivelli"<notifications@github.com>;
发送时间: 2019年12月31日(星期二) 下午2:37
收件人: "apache/bookkeeper"<bookkeeper@noreply.github.com>;
抄送: "Just do it "<278903642@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/bookkeeper] Fix batch read data in cache does not take effect (#2231)
Hi.
Can you please explain your problem and the fix?
We should also add a test case to demonstrate that the fix works and in order to prevent regressions in the future.
Thank you for contributing your fix
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Author
|
retest this please |
jiazhai
approved these changes
Jan 6, 2020
jiazhai
approved these changes
Jan 7, 2020
Member
|
rebuild java11 |
Member
|
@eolivelli is helping fix the CI issue. |
eolivelli
requested changes
Jan 8, 2020
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Yes I am working on CI.
I wonder if we can add some unit test, even using mockito
sijie
approved these changes
Jan 26, 2020
Member
|
I think the code is obvious and the code path should have been already covered by existing tests. So this change should be good to go. |
Contributor
Author
|
retest this please |
Contributor
|
I am sorry but the magic comment doesn't work anymore with github actions. |
Contributor
|
@liudezhi2098 can you please merge with master branch so that CI kicks in again ? thanks in advance |
jiazhai
approved these changes
Mar 17, 2020
liudezhi2098
force-pushed
the
issue-branch-xxx
branch
from
3499dfc to
7c15f5c
Compare
Ghatage
pushed a commit
to Ghatage/bookkeeper
that referenced
this pull request
Jun 19, 2020
Descriptions of the changes in this PR: ### Motivation Fix batch read data in cache does not take effect ### Changes (Describe: what changes you have made) Master Issue: apache#2230 Fixes: apache#2230 Reviewers: Jia Zhai <zhaijia@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <None> This closes apache#2231 from liudezhi2098/issue-branch-xxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Fix batch read data in cache does not take effect
Changes
(Describe: what changes you have made)
Master Issue: #2230
Fixes: #2230