Create ledgersRootPath recursively for 'bin/bookkeeper shell metaformat'#2237
Merged
sijie merged 3 commits intoapache:masterfrom Jan 22, 2020
Merged
Create ledgersRootPath recursively for 'bin/bookkeeper shell metaformat'#2237sijie merged 3 commits intoapache:masterfrom
sijie merged 3 commits intoapache:masterfrom
Conversation
eolivelli
requested changes
Jan 10, 2020
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Awesome.
Can you please add a test?
In fact we had this feature but it was lost, there was no regression tests
Contributor
|
We will cherry pick to 4.10 release branch |
Contributor
Author
|
Sorry for the late reply，added |
Contributor
|
retest this please |
Contributor
|
This error has also been hit on Pravega by @RaulGracia |
Contributor
|
@SunDapeng1 you have a javac warning to fix please: |
sijie
approved these changes
Jan 22, 2020
Ghatage
pushed a commit
to Ghatage/bookkeeper
that referenced
this pull request
Jun 19, 2020
Create ledgersRootPath recursively for `bin/bookkeeper shell metaformat`. The existence of any parent znodes is not an error condition Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <None> This closes apache#2237 from SunDapeng1/branch-2236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create ledgersRootPath recursively for
bin/bookkeeper shell metaformat. The existence of any parent znodes is not an error condition