Fixes vertx can not receive the request body#2241
Merged
eolivelli merged 9 commits intoapache:masterfrom Mar 9, 2020
Merged
Conversation
--- *Motivation* Vertx can not receive the request body so that the REST API can not work well if you have a request with body. *Modifications* - Add body handler for the vertx http service *Verify this change* - Pass the test `testHttpMethodsWithBody`
eolivelli
approved these changes
Jan 13, 2020
Contributor
|
Thank you. |
Member
Author
|
@eolivelli my pleasure. All ci has been passed. PTAL. Thanks. |
Contributor
|
@jiazhai can you please take a look ? |
c9ddfa3 to
6d68332
Compare
Contributor
|
Travis did not pass please check |
Member
Author
|
The Travis failed with this |
Contributor
|
sure, just click on "Restart Job" Button |
Member
|
@zymap Can you please fix the style issues? |
Contributor
|
@sijie I would like to merge this change, can you please take a look ? |
Contributor
|
@zymap can you please rebase to current master ? |
sijie
approved these changes
Mar 6, 2020
Ghatage
pushed a commit
to Ghatage/bookkeeper
that referenced
this pull request
Jun 19, 2020
--- *Motivation* Vertx can not receive the request body so that the REST API can not work well if you have a request with body. *Modifications* - Add body handler for the vertx http service *Verify this change* - Pass the test `testHttpMethodsWithBody` Descriptions of the changes in this PR: ### Motivation (Explain: why you're making that change, what is the problem you're trying to solve) ### Changes (Describe: what changes you have made) Master Issue: #<master-issue-number> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes apache#2241 from zymap/fix-can-not-read-body
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Vertx can not receive the request body so that the REST API
can not work well if you have a request with body.
Modifications
Verify this change
testHttpMethodsWithBodyDescriptions of the changes in this PR:
Motivation
(Explain: why you're making that change, what is the problem you're trying to solve)
Changes
(Describe: what changes you have made)
Master Issue: #