Issue 2311: Adds support to decode metadata in the API that list ledgers#2312
Issue 2311: Adds support to decode metadata in the API that list ledgers#2312eolivelli merged 7 commits intoapache:masterfrom
Conversation
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
But please add a test
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
we have fixed the problem on Integration tests.
This patch is now good to go.
Let's wait for another binding +1 before merging the patch to master
|
can you please merge with current master? |
The page shows that it has to be someone with write access can merge the PR... |
|
Sorry git merge apache/master Assuming that xxxx is your branch and 'apache' is your git remote repository for main apache Bookkeeper repository |
b7c8af1 to
cb78528
Compare
Sure, I have rebased the PR, please take a look. |
|
I have restarted integration tests |
…st ledgers Descriptions of the changes in this PR: ### Motivation The current list ledgers API output the metadata in a serialized binary format, which is not friendly to human operators and external tools, and is not consistent with the output of the [API that gets the metadata](https://bookkeeper.apache.org/docs/4.9.2/admin/http/#endpoint-apiv1ledgermetadataledger_idledger_id). ### Changes The PR adds a parameter called `decode_meta`, and output the ledger metadata in decoded format when the parameter presents and the value of it is 'true'. Master Issue: apache#2311 Reviewers: Sijie Guo <None>, Enrico Olivelli <eolivelli@gmail.com> This closes apache#2312 from fantapsody/decode_metadata, closes apache#2311
Descriptions of the changes in this PR:
Motivation
The current list ledgers API output the metadata in a serialized binary format, which is not friendly to human operators and external tools, and is not consistent with the output of the API that gets the metadata.
Changes
The PR adds a parameter called
decode_meta, and output the ledger metadata in decoded format when the parameter presents and the value of it is 'true'.Master Issue: #2311