The latency of BenchThroughputLatency may be wrong due to Integer overflow when we do a large scale benchmark test #2381
Merged
sijie merged 1 commit intoapache:masterfrom Aug 13, 2020
Conversation
…rflow when we do a large scale benchmark test
Contributor
|
@rdhabalia @jiazhai PTAL |
Contributor
|
rerun failure tests |
sijie
approved these changes
Aug 13, 2020
sijie
pushed a commit
that referenced
this pull request
Aug 13, 2020
…rflow when we do a large scale benchmark test - When` latency.size` is is more than `20,000,000`(e.g, `25000000`), `(size * percentile) / 100` will be a negative number due to Integer overflow and the latency will be wrong. - For example: `size `= 25000000, `percentile `= 99, `sampleSize `= -18199672 Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <None> This closes #2381 from maoling/BenchThroughputLatency-latency-wrong (cherry picked from commit 43fab26) Signed-off-by: Sijie Guo <sijie@apache.org>
Ghatage
pushed a commit
to Ghatage/bookkeeper
that referenced
this pull request
Oct 6, 2020
…rflow when we do a large scale benchmark test - When` latency.size` is is more than `20,000,000`(e.g, `25000000`), `(size * percentile) / 100` will be a negative number due to Integer overflow and the latency will be wrong. - For example: `size `= 25000000, `percentile `= 99, `sampleSize `= -18199672 Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <None> This closes apache#2381 from maoling/BenchThroughputLatency-latency-wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latency.sizeis is more than20,000,000(e.g,25000000),(size * percentile) / 100will be a negative number due to Integer overflow and the latency will be wrong.size= 25000000,percentile= 99,sampleSize= -18199672