Conversation
eolivelli
left a comment
There was a problem hiding this comment.
it is not a good practice to use absolute HTTP URL
can you simply fix the relative link ?
|
@eolivelli The second link can be easily changed to a relative link. But the file pointed to by the first link is empty. site/docs/4.10.0/reference/metrics.md This is the path. Should I modify this file at the same time? |
|
@sijie The file pointed to by the first link is empty. site/docs/4.10.0/reference/metrics.md This is the path. Should I modify this file at the same time? If so, what should be the content? Thank you. |
|
Since v4.5.0, the
|
|
BTW, would you add "Fixes" before "#1979", so when a PR is merged, the related issue will be closed automatically. |
|
@jennifer88huang Thanks very much for your feedback. If we adopt option 1, what should be added? Or you prefer option 2? |
|
@jennifer88huang Which option do you prefer? Shall we remove the link for metrics? |
Yes, if no one could provide the whole content for metrics reference at the moment, just remove the link; if the content is ready, we can add it again. |
|
@jennifer88huang Got it. Thanks. Will do soon. |
Fixes #1979 The link for `Metrics` is broken. However, the `Metrics` file is empty. Therefore, I temporarily removed the link in all versions. The same problem happened to `configuration parameters`. I closed pr #2386 as it brought changes from the master instead of a new branch. Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2400 from sijia-w/fix-1979, closes #1979
Fixes #1979
Fix the links for metrics and the configuration parameters.