Issue 2170: Cleaned up error message for NoNodeException for lostBook…#2452
Merged
Ghatage merged 1 commit intoapache:masterfrom Oct 23, 2020
Merged
Issue 2170: Cleaned up error message for NoNodeException for lostBook…#2452Ghatage merged 1 commit intoapache:masterfrom
Ghatage merged 1 commit intoapache:masterfrom
Conversation
…ieRecoveryDelay when Auditor is not initialized.
eolivelli
approved these changes
Oct 23, 2020
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
That stackteace was very annoying. Thanks
Contributor
|
@Ghatage is it generally better to not merge your own pull requests. Now that you are onboard I see that we will move at a faster pace |
Contributor
Author
|
@Ghatage is it generally better to not merge your own pull requests
Understood!
…On Fri, Oct 23, 2020, 1:38 AM Enrico Olivelli ***@***.***> wrote:
@Ghatage <https://github.com/Ghatage> is it generally better to not merge
your own pull requests.
Recently I committed my own patches after waiting the approval of other
committers but that was because we haven't many active committers who had
time to merge.
Now that you are onboard I see that we will move at a faster pace
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2452 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAX6QQJ6MI32ACJDQ3SDA6TSME6I5ANCNFSM4S33URMA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ieRecoveryDelay when Auditor is not initialized.
Motivation
If Auditor has not been initialized, running
lostBookieRecoveryDelayfrom bookie shell will result in a stack trace andNoNodeException.Changes
Added a catch clause which:
lostbookierecoverydelayhas not been created yet.Master Issue: #2170