Skip to content

Issue 2170: Cleaned up error message for NoNodeException for lostBook…#2452

Merged
Ghatage merged 1 commit intoapache:masterfrom
Ghatage:BOOKEEPER-2170
Oct 23, 2020
Merged

Issue 2170: Cleaned up error message for NoNodeException for lostBook…#2452
Ghatage merged 1 commit intoapache:masterfrom
Ghatage:BOOKEEPER-2170

Conversation

@Ghatage
Copy link
Contributor

@Ghatage Ghatage commented Oct 22, 2020

…ieRecoveryDelay when Auditor is not initialized.

Motivation

If Auditor has not been initialized, running lostBookieRecoveryDelay from bookie shell will result in a stack trace and NoNodeException.

Changes

Added a catch clause which:

  • Cleans up stack trace
  • Explains that the Auditor is not up yet, which means the znode for lostbookierecoverydelay has not been created yet.
  • Prints exception

Master Issue: #2170

…ieRecoveryDelay when Auditor is not initialized.
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

That stackteace was very annoying. Thanks

@Ghatage Ghatage added this to the 4.12.0 milestone Oct 23, 2020
@Ghatage Ghatage merged commit 51bfd22 into apache:master Oct 23, 2020
@eolivelli
Copy link
Contributor

@Ghatage is it generally better to not merge your own pull requests.
Recently I committed my own patches after waiting the approval of other committers but that was because we haven't many active committers who had time to merge.

Now that you are onboard I see that we will move at a faster pace

@Ghatage
Copy link
Contributor Author

Ghatage commented Oct 23, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants