Issue 258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed#259
Closed
sijie wants to merge 2 commits into
Closed
Issue 258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed#259sijie wants to merge 2 commits into
sijie wants to merge 2 commits into
Conversation
…eNewIndexFile failed Reason: in c49621b, we allow creating FileInfo even when disk is full to allow fence requests succeed at this case. it is conflicted with Charan's change. Since there is already a setting to configure the min usable size to allow index file creation. if we configure that to be zero, it is same as allowing index file creation even disks are full. so removing the fallback logic introduced in c49621b.
eolivelli
approved these changes
Jul 19, 2017
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
+1 the tests are passing, the change is safe for me
reddycharan
pushed a commit
to reddycharan/bookkeeper
that referenced
this pull request
Dec 13, 2017
…ionTimeOut failed Descriptions of the changes in this PR: Construct new zookeeper client to ensure the tests get new zookeeper session. (this change is based on 77c7721 ) Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> This closes apache#259 from sijie/issue_258, closes apache#258 (cherry picked from commit 11fdac3) Also, remove the @ignore from the test.
athanatos
pushed a commit
to athanatos/bookkeeper
that referenced
this pull request
Jan 25, 2019
…NonExistingOpCode On branch 3.5, testNonExistingOpCode appears to always take 30 seconds to execute (far too long): https://builds.apache.org/job/ZooKeeper_branch35_jdk7/967/testReport/org.apache.zookeeper.test/ClientTest/testNonExistingOpCode/history/ The reason for this is a call to `zk.testableWaitForShutdown(CONNECTION_TIMEOUT)` while waiting for the client to disconnect after it sent a request with a bad opcode to the server. The call to `testableWaitForShutdown` never actually asserts anything and effectively just hangs for CONNECTION_TIMEOUT (30 seconds) and returns because the client reconnects to the server. This patch replaces `zk.testableWaitForShutdown(CONNECTION_TIMEOUT)` with `watcher.waitForDisconnected(5000)` which is a better way to detect if we have been disconnected. Author: Abraham Fine <afine@apache.org> Reviewers: Michael Han <hanm@apache.org> Closes apache#259 from afine/ZOOKEEPER-2786_br3.5 (cherry picked from commit c89784cc57bdcc88de89da6993d758225585d33e) Signed-off-by: Michael Han <hanm@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Construct new zookeeper client to ensure the tests get new zookeeper session.
(this change is based on 77c7721 )