Cleanup code in RackawareEnsemblePlacementPolicyImpl#2920
Merged
eolivelli merged 2 commits intoapache:masterfrom Dec 11, 2021
Merged
Cleanup code in RackawareEnsemblePlacementPolicyImpl#2920eolivelli merged 2 commits intoapache:masterfrom
eolivelli merged 2 commits intoapache:masterfrom
Conversation
1.RackawareEnsemblePlacementPolicyImpl.REPP_DNS_RESOLVER_CLASS has be existed in his parent class 2.NetUtils.logger is no use
Member
Author
|
@Vanlightly @coolbeevip |
eolivelli
changed the title
nicoloboschi
approved these changes
Dec 2, 2021
Member
Author
|
@eolivelli @nicoloboschi |
dlg99
approved these changes
Dec 2, 2021
Member
Author
|
@dlg99 @nicoloboschi @eolivelli |
Contributor
|
rerun failure checks |
hezhangjian
approved these changes
Dec 4, 2021
Member
Author
|
@nicoloboschi @dlg99 @eolivelli |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Cleanup code: 1.RackawareEnsemblePlacementPolicyImpl.REPP_DNS_RESOLVER_CLASS has be existed in his parent class 2.NetUtils.logger is no use * remove no use import Co-authored-by: lushiji <lushiji@didiglobal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Simple code cleanup
Changes
1.RackawareEnsemblePlacementPolicyImpl.REPP_DNS_RESOLVER_CLASS has be existed in his parent class,so clean in the child class
2.NetUtils.logger is no use