wait a BackOff Time when rereplicate failed#2967
Merged
pkumar-singh merged 2 commits intoapache:masterfrom Jan 13, 2022
Merged
Conversation
when the other bookie restart,rereplicate will run failed for BookieIdNotResolvedException, so wait a BackOff Time when rereplicate run failed
nicoloboschi
requested changes
Dec 26, 2021
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
Show resolved
Hide resolved
Member
Author
|
rerun failure checks |
Member
Author
|
@nicoloboschi @dlg99 @eolivelli |
eolivelli
reviewed
Dec 29, 2021
| } | ||
| } catch (InterruptedException e) { | ||
| LOG.info("InterruptedException " | ||
| LOG.error("InterruptedException " |
Contributor
There was a problem hiding this comment.
Why are you changing this to ERROR?
Member
Author
There was a problem hiding this comment.
@eolivelli
it may be manual or unexcept interrupted, this log's level should be warn or error, I think
Member
Author
|
@pkumar-singh |
Member
Author
|
Member
|
@eolivelli If seems OK to you kindly approve and merge. |
Member
Author
|
@eolivelli |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* reduce CPU Resource: when the other bookie restart,rereplicate will run failed for BookieIdNotResolvedException, so wait a BackOff Time when rereplicate run failed * clean error code Co-authored-by: lushiji <lushiji@didiglobal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
the other bookie restart,rereplicate will run failed for BookieIdNotResolvedException when recover the IN_RECOVERY ledger,
then the ReplicationWorker will cost more cpu time during the other bookie is restarting.
so wait a BackOff Time when rereplicate run failed to reduce CPU Resource
Changes