Issue 320: add scripts for publishing new website to staging and apache#322
Closed
sijie wants to merge 13 commits into
Closed
Issue 320: add scripts for publishing new website to staging and apache#322sijie wants to merge 13 commits into
sijie wants to merge 13 commits into
Conversation
lucperkins
approved these changes
Jul 29, 2017
Contributor
lucperkins
left a comment
lucperkins
left a comment
There was a problem hiding this comment.
One suggested change. Otherwise +1.
| # under the License. | ||
| # | ||
|
|
||
| ROOT_DIR=$(git rev-parse --show-toplevel) |
Contributor
There was a problem hiding this comment.
For some of these variables that are set in both publish-website.sh and staging-website.sh, I'd recommend putting those in common.sh and adding source scripts/common.sh at the top. Keeps the scripts more DRY.
Contributor
There was a problem hiding this comment.
Not a blocker, though. LGTM otherwise.
Member
Author
There was a problem hiding this comment.
good suggestion. I will make the changes.
Member
Author
There was a problem hiding this comment.
@lucperkins I moved the common variables to the common.sh
athanatos
pushed a commit
to athanatos/bookkeeper
that referenced
this pull request
Jan 25, 2019
Author: Fangmin Lyu <allenlyu@fb.com> Reviewers: Michael Han <hanm@apache.org>, maoling <maoling199210191@sina.com> Closes apache#322 from lvfangmin/ZOOKEEPER-2853
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR: