Enable Netty and BookKeeper IO optimizations on jdk17#3234
Merged
merlimat merged 2 commits intoapache:masterfrom May 11, 2022
Merged
Enable Netty and BookKeeper IO optimizations on jdk17#3234merlimat merged 2 commits intoapache:masterfrom
merlimat merged 2 commits intoapache:masterfrom
Conversation
1 task
Contributor
Author
|
rerun failure checks |
hezhangjian
approved these changes
Apr 24, 2022
dlg99
approved these changes
Apr 25, 2022
Member
merlimat
approved these changes
May 5, 2022
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Enable netty optimization and BK native IO on jdk17 * zip and better docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
Starting from JDK17 the reflection is not allowed in the jdk internals modules. Until JDK16, it will print a warning like this:
With JDK17, BookKeeper and Netty work well even if this optimization are not allowed. In order to continue to use them, we need to open the required modules
For Netty, we can follow this issue: netty/netty#12265
For BookKeeper, I identified DirectMemoryCRC32Digest and NativeIO classes
Changes
--add-opensinstruction