Skip to content

Remove gradle build script#3340

Merged
hezhangjian merged 2 commits intoapache:masterfrom
hezhangjian:remove-gradle-build-script
Jun 17, 2022
Merged

Remove gradle build script#3340
hezhangjian merged 2 commits intoapache:masterfrom
hezhangjian:remove-gradle-build-script

Conversation

@hezhangjian
Copy link
Member

@hezhangjian hezhangjian commented Jun 16, 2022

Motivation

Remove gradle build script
See
https://lists.apache.org/thread/k3pdlpbvkzt061338fkxtppq3z70nk03
https://lists.apache.org/thread/os28qm4t0kf74q2k3lzsmnnpr0lnm6zc

Changes

  • delete gradle build script
  • add netty-buffer dependency on module distributedlog-core-shaded-test to fix broken master tests.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hezhangjian
Copy link
Member Author

rerun failure checks

@hezhangjian
Copy link
Member Author

the failure actions are not related to this PR.

@hezhangjian hezhangjian merged commit 708f890 into apache:master Jun 17, 2022
@hezhangjian hezhangjian deleted the remove-gradle-build-script branch June 17, 2022 00:39
@hangc0276
Copy link
Contributor

This PR breaks the backward-compat test in CI, Please help take a look, thanks @shoothzj
#3345

@hezhangjian
Copy link
Member Author

@hangc0276 I will try, my computer is still under repaired. Probably not so fast.

@hangc0276
Copy link
Contributor

@hangc0276 I will try, my computer is still under repaired. Probably not so fast.

@shoothzj I'm not sure whether this Pr also breaks other CI tests, we'd better check it one by one.

If the backward-compat test in CI can't be repaired in a short time, I will revert the CI to gradle.

@hezhangjian
Copy link
Member Author

@hangc0276 It's not worked before. See #2937. I will try to fix maven tests ASAP.

@hangc0276
Copy link
Contributor

@hangc0276 It's not worked before. See #2937. I will try to fix maven tests ASAP.

@shoothzj In gradle, it woks before.
https://github.com/apache/bookkeeper/runs/5953506864?check_suite_focus=true

@hangc0276 hangc0276 added this to the 4.16.0 milestone Jul 25, 2022
zymap pushed a commit that referenced this pull request Aug 3, 2022
Remove gradle build script
See
https://lists.apache.org/thread/k3pdlpbvkzt061338fkxtppq3z70nk03
https://lists.apache.org/thread/os28qm4t0kf74q2k3lzsmnnpr0lnm6zc
- delete gradle build script
- add `netty-buffer` dependency on module `distributedlog-core-shaded-test` to fix broken master tests.

(cherry picked from commit 708f890)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
### Motivation
Remove gradle build script
See 
https://lists.apache.org/thread/k3pdlpbvkzt061338fkxtppq3z70nk03
https://lists.apache.org/thread/os28qm4t0kf74q2k3lzsmnnpr0lnm6zc
### Changes
- delete gradle build script
- add `netty-buffer` dependency on module `distributedlog-core-shaded-test` to fix broken master tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments