Skip to content

Issue 344: add a releases page#345

Closed
sijie wants to merge 7 commits intoapache:masterfrom
sijie:redirection_on_old_releases
Closed

Issue 344: add a releases page#345
sijie wants to merge 7 commits intoapache:masterfrom
sijie:redirection_on_old_releases

Conversation

@sijie
Copy link
Copy Markdown
Member

@sijie sijie commented Aug 1, 2017

Descriptions of the changes in this PR:

Add a releases page for keeping the history of apache releases.

@sijie sijie added this to the 4.5.0 milestone Aug 1, 2017
@sijie sijie self-assigned this Aug 1, 2017
@sijie sijie requested a review from merlimat August 1, 2017 18:35
@sijie
Copy link
Copy Markdown
Member Author

sijie commented Aug 1, 2017

/cc @lucperkins for a review

This is basically the copy for http://bookkeeper.apache.org/releases.html

You can review this from my staging site: https://sijie.github.io/bookkeeper-staging-site/releases/

Copy link
Copy Markdown
Contributor

@lucperkins lucperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 once changes have been made

Comment thread site/releases.md

## News

### 16 May, 2016: release 4.4.0 available
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to generate this section using a template, but I can do that later

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed +1

Comment thread site/releases.md Outdated
## Getting Started

Once you've downloaded a BookKeeper release, instructions on getting up and running with a standalone cluster that you can run your laptop can be found
in [Run BookKeeper locally]({{ site.baseurl }}/docs/getting-started/run-locally).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using baseurl, make sure not to include a slash, as this will break the link when you run it locally (when you run locally, the baseurl is /, which creates // URLs).

In this particular case it should be {{ site.baseurl }}docs/getting-started/run-locally.

Confusing and kind of annoying. Later on we can remove all of these baseurl links.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove '/'

@sijie sijie closed this in 3713aa7 Aug 1, 2017
@sijie sijie deleted the redirection_on_old_releases branch July 16, 2018 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants