Skip to content

<Issue #3534>[website]fix website mailing_lists_url/slack_url#3535

Merged
hangc0276 merged 3 commits intoapache:masterfrom
zwOvO:patch_website_var_url
Oct 20, 2022
Merged

<Issue #3534>[website]fix website mailing_lists_url/slack_url#3535
hangc0276 merged 3 commits intoapache:masterfrom
zwOvO:patch_website_var_url

Conversation

@zwOvO
Copy link
Contributor

@zwOvO zwOvO commented Oct 15, 2022

Descriptions of the changes in this PR:
The community related variables are not replaced

Motivation

Poor user experience

Changes

1、modify Upgrade page template variables
2、add variables to config

Master Issue: #3534

image

Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwOvO zwOvO changed the title [website]fix website mailing_lists_url/slack_url #3534 <Issue #3534>[website]fix website mailing_lists_url/slack_url Oct 16, 2022
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use relative paths

zwOvO and others added 2 commits October 17, 2022 16:41
Co-authored-by: Nicolò Boschi <boschi1997@gmail.com>
@zwOvO zwOvO requested a review from nicoloboschi October 17, 2022 08:45
@hangc0276 hangc0276 merged commit 255416a into apache:master Oct 20, 2022
@hangc0276 hangc0276 added this to the 4.16.0 milestone Oct 20, 2022
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
…pache#3535)

Descriptions of the changes in this PR:
The community related variables are not replaced

### Motivation
Poor user experience

### Changes
1、modify Upgrade page template variables
2、add  variables to config

Master Issue: apache#3534

![image](https://user-images.githubusercontent.com/18533252/195989997-63ac71d3-8d2a-425d-9c45-f0816f18cd80.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants