In avoid to call zk frequently, using watcher to watch the change#3554
Closed
gaozhangmin wants to merge 1 commit intoapache:masterfrom
Closed
In avoid to call zk frequently, using watcher to watch the change#3554gaozhangmin wants to merge 1 commit intoapache:masterfrom
gaozhangmin wants to merge 1 commit intoapache:masterfrom
Conversation
gaozhangmin
force-pushed
the
watcher-isLedgerReplicationEnabled
branch
2 times, most recently
from
e8a135d to
6bd431e
Compare
Contributor
Author
|
@dlg99 PTAL Thx |
gaozhangmin
changed the title
gaozhangmin
changed the title
gaozhangmin
force-pushed
the
watcher-isLedgerReplicationEnabled
branch
from
d1dfd27 to
deec13a
Compare
eolivelli
requested changes
Oct 26, 2022
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
Show resolved
Hide resolved
eolivelli
requested changes
Oct 26, 2022
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
Outdated
Show resolved
Hide resolved
dlg99
requested changes
Oct 26, 2022
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
Outdated
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerUnderreplicationManager.java
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
watcher-isLedgerReplicationEnabled
branch
2 times, most recently
from
763f512 to
02f5160
Compare
gaozhangmin
requested review from
dlg99 and
eolivelli
and removed request for
dlg99 and
eolivelli
Contributor
Author
|
rerun failure checks |
gaozhangmin
requested review from
dlg99 and
eolivelli
and removed request for
dlg99 and
eolivelli
Contributor
Author
|
@eolivelli @dlg99 PTAL |
merlimat
reviewed
Nov 3, 2022
Contributor
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
I think the repeated calls to ZK are not be a problem in Pulsar, since 2.10, because the calls to ZK are already internally cached.
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerUnderreplicationManager.java
Outdated
Show resolved
Hide resolved
…isLedgerReplicationEnabled
gaozhangmin
force-pushed
the
watcher-isLedgerReplicationEnabled
branch
from
e7587d4 to
380d175
Compare
Contributor
Author
|
rerun failure checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3358