Skip to content

[Branch-4.14] Fix TLS test stat npe#3558

Closed
horizonzy wants to merge 1 commit into
apache:branch-4.14from
horizonzy:fix-state-npe
Closed

[Branch-4.14] Fix TLS test stat npe#3558
horizonzy wants to merge 1 commit into
apache:branch-4.14from
horizonzy:fix-state-npe

Conversation

@horizonzy
Copy link
Copy Markdown
Member

@horizonzy horizonzy commented Oct 20, 2022

Patch for #3557

Descriptions of the changes in this PR:

The stat is per_channel_bookie_client.bookie_127_0_0_1_60541.FAILED_TLS_HANDSHAKE_COUNTER
The input is: per_channel_bookie_client.bookie_127_0_0_1:60541.FAILED_TLS_HANDSHAKE_COUNTER

The input 127_0_0_1:60541, the : should be replaced by _

The same logic at master branch.

public static String buildStatsCounterPathFromBookieID(BookieId bookieId) {
return bookieId.toString().replace('.', '_').replace('-', '_').replace(":", "_");
}

@horizonzy
Copy link
Copy Markdown
Member Author

@hangc0276 @dlg99

@horizonzy horizonzy changed the title [Branch-4.14] Fix stat npe [Branch-4.14] Fix TLS test stat npe Oct 20, 2022
@horizonzy
Copy link
Copy Markdown
Member Author

Appned this logic to #3557, so close this.

@horizonzy horizonzy closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant