Monitor timeout tasks in executor#3585
Closed
gaozhangmin wants to merge 4 commits intoapache:masterfrom
Closed
Conversation
gaozhangmin
changed the title
merlimat
requested changes
Oct 31, 2022
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/SingleThreadExecutor.java
Outdated
Show resolved
Hide resolved
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/SingleThreadExecutor.java
Outdated
Show resolved
Hide resolved
hangc0276
requested changes
Nov 3, 2022
Contributor
hangc0276
left a comment
hangc0276
left a comment
There was a problem hiding this comment.
Why not check when the task actually runs?
gaozhangmin
force-pushed
the
timeout-tasks-metrics
branch
from
28d8486 to
e0fbba1
Compare
gaozhangmin
requested review from
hangc0276 and
merlimat
and removed request for
hangc0276 and
merlimat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Monitor slow tasks, add metric
thread_executor_tasks_timeoutinSingleThreadExecutor