waitTimeoutOnResponseBackpressureMs should be gt 0#3600
Closed
gaozhangmin wants to merge 1 commit into
Closed
Conversation
hangc0276
requested changes
Nov 3, 2022
Contributor
hangc0276
left a comment
There was a problem hiding this comment.
0 to allow request to fail immediately
zymap
requested changes
Nov 3, 2022
|
|
||
| final long timeOut = requestProcessor.getWaitTimeoutOnBackpressureMillis(); | ||
| if (timeOut >= 0 && !channel.isWritable()) { | ||
| if (timeOut > 0 && !channel.isWritable()) { |
Member
There was a problem hiding this comment.
timeout is 0 should fail immediately, it is expected.
Contributor
Author
There was a problem hiding this comment.
Is it ok when timeout is 0 and blacklistedChannels = Optional.empty() ? @zymap @hangc0276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update
timeOut >= 0totimeout > 0, it make no sense executing back pressure whenwaitTimeoutOnBackpressureMillis=0