Dont validate CompactionInterval when compaction is disabled#3664
Merged
Conversation
dlg99
approved these changes
Nov 22, 2022
zymap
approved these changes
Nov 24, 2022
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
…3664) ### Motivation Currently, We cannot disable minorCompaction and majorCompaction by setting interval to -1, with `gcWaitTime` is enabled. ### Changes Don't validate CompactionInterval if compaction is disabled
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…3664) ### Motivation Currently, We cannot disable minorCompaction and majorCompaction by setting interval to -1, with `gcWaitTime` is enabled. ### Changes Don't validate CompactionInterval if compaction is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, We cannot disable minorCompaction and majorCompaction by setting interval to -1, with
gcWaitTimeis enabled.Changes
Don't validate CompactionInterval if compaction is disabled