Skip to content

Run CI when a pull request contains doc changes#3671

Merged
nicoloboschi merged 2 commits into
apache:masterfrom
nicoloboschi:fix-checkstytle
Nov 25, 2022
Merged

Run CI when a pull request contains doc changes#3671
nicoloboschi merged 2 commits into
apache:masterfrom
nicoloboschi:fix-checkstytle

Conversation

@nicoloboschi
Copy link
Copy Markdown
Contributor

@nicoloboschi nicoloboschi commented Nov 25, 2022 •
edited
Loading

Motivation

Master build fails due to checsktyle

Error:  /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/BookieSanityService.java:26:1: Extra separation in import group before 'org.apache.bookkeeper.common.util.JsonUtil' [ImportOrder]
Error:  /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/BookieSanityService.java:36:1: Extra separation in import group before 'lombok.Data' [ImportOrder]
Error:  /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/BookieSanityService.java:36:1: Import lombok.Data appears after other imports that it should precede [ImportOrder]

The problem is that if a pull contains doc changes, all CI checks are skipped

Changes

  • Improve checks changes detection to skip code tests only if the changes are ONLY about docs
  • Same as above for owasp check

@nicoloboschi nicoloboschi changed the title Fix checkstyle on master branch Fix CI when also doc is updated Nov 25, 2022
@nicoloboschi nicoloboschi changed the title Fix CI when also doc is updated Run CI when a pull request contains doc changes Nov 25, 2022
@nicoloboschi nicoloboschi requested review from eolivelli and zymap and removed request for zymap November 25, 2022 09:28
@nicoloboschi nicoloboschi self-assigned this Nov 25, 2022
@nicoloboschi nicoloboschi merged commit aa6d3f9 into apache:master Nov 25, 2022
yaalsn pushed a commit to yaalsn/bookkeeper that referenced this pull request Jan 30, 2023
@nicoloboschi @yaalsn
Run CI when a pull request contains doc changes (apache#3671)
ce809c6 
* Run CI when a pull request contains doc changes

* Push filters
@hangc0276 hangc0276 added this to the 4.16.0 milestone Mar 21, 2023
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@nicoloboschi
Run CI when a pull request contains doc changes (apache#3671)
a65b221 
* Run CI when a pull request contains doc changes

* Push filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eolivelli eolivelli eolivelli approved these changes

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@hezhangjian hezhangjian Awaiting requested review from hezhangjian

@zymap zymap Awaiting requested review from zymap

Assignees

@nicoloboschi nicoloboschi

Labels

None yet

Projects

None yet

Milestone

4.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nicoloboschi @eolivelli @hangc0276 @hezhangjian