Remove compiling with -Werror to support Java 19

[merlimat]

Motivation

Building BK with Java 19 fails because there is a deprecation warning and it's being treated as an error.

In a few places, we are using Thread.getId() which has been deprecated since Java 19. There is now a new replacement: Thread.getThreadId().

The problem is that we cannot use the new method (which is only in Java 19+) and the build fails with the deprecated method.

I believe the best solution is to not use -Werrror flag in the build.

[eolivelli]

+1

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.83%. Comparing base (6f09c60) to head (e4439ea).
⚠️ Report is 552 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3820      +/-   ##
============================================
+ Coverage     44.28%   49.83%   +5.54%     
- Complexity     4375     4815     +440     
============================================
  Files           473      473              
  Lines         40963    40963              
  Branches       5240     5240              
============================================
+ Hits          18141    20413    +2272     
+ Misses        20937    18520    -2417     
- Partials       1885     2030     +145     

Flag	Coverage Δ
bookie	39.92% <ø> (?)
client	?
remaining	29.72% <ø> (?)
tls	20.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.