Skip to content

Fix: typo for ledger-metadata param: restorefromfile#3823

Merged
merlimat merged 1 commit intoapache:masterfrom
rdhabalia:cli_typo_meta
Feb 28, 2023
Merged

Fix: typo for ledger-metadata param: restorefromfile#3823
merlimat merged 1 commit intoapache:masterfrom
rdhabalia:cli_typo_meta

Conversation

@rdhabalia
Copy link
Copy Markdown
Contributor

Motivation

#2019 has introduced a typo in ledgerMetadata bk-shell command which checks invalid input param restorefromefile instead of restorefromfile. so, this PR fixes that typo which will not cause any compatibility issue for this functionality as such.

@rdhabalia rdhabalia added this to the 4.17.0 milestone Feb 27, 2023
@rdhabalia rdhabalia self-assigned this Feb 27, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #3823 (df7b570) into master (c389b96) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3823      +/-   ##
============================================
- Coverage     47.46%   47.43%   -0.03%     
+ Complexity     4570     4566       -4     
============================================
  Files           473      473              
  Lines         40963    40963              
  Branches       5240     5240              
============================================
- Hits          19443    19431      -12     
- Misses        19524    19544      +20     
+ Partials       1996     1988       -8     
Flag Coverage Δ
remaining 29.55% <0.00%> (+<0.01%) ⬆️
replication 41.37% <0.00%> (-0.08%) ⬇️
tls 21.07% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/apache/bookkeeper/bookie/BookieShell.java 0.67% <0.00%> (ø)
...ols/cli/commands/client/LedgerMetaDataCommand.java 0.00% <0.00%> (ø)
...apache/bookkeeper/verifier/BookkeeperVerifier.java 80.30% <0.00%> (-7.58%) ⬇️
...in/java/org/apache/bookkeeper/bookie/FileInfo.java 53.87% <0.00%> (-5.91%) ⬇️
.../main/java/org/apache/bookkeeper/util/ZkUtils.java 77.31% <0.00%> (-3.10%) ⬇️
.../apache/bookkeeper/proto/ReadEntryProcessorV3.java 60.41% <0.00%> (-2.09%) ⬇️
...keeper/util/collections/ConcurrentOpenHashMap.java 88.69% <0.00%> (-1.72%) ⬇️
...ava/org/apache/bookkeeper/client/PendingAddOp.java 63.10% <0.00%> (-0.98%) ⬇️
...apache/bookkeeper/client/ReadOnlyLedgerHandle.java 64.33% <0.00%> (-0.70%) ⬇️
...ava/org/apache/bookkeeper/client/LedgerHandle.java 49.22% <0.00%> (-0.29%) ⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@merlimat merlimat merged commit 0ca4fe2 into apache:master Feb 28, 2023
@hangc0276 hangc0276 modified the milestones: 4.17.0, 4.16.0 Mar 21, 2023
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants