Flaky Test: Build with windows on JDK 11#4675
Closed
liangyepianzhou wants to merge 1 commit intoapache:masterfrom
Closed
Flaky Test: Build with windows on JDK 11#4675liangyepianzhou wants to merge 1 commit intoapache:masterfrom
liangyepianzhou wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
rerun failure checks |
Contributor
Author
|
rerun failure checks |
1 similar comment
Contributor
Author
|
rerun failure checks |
zymap
reviewed
Oct 22, 2025
Member
zymap
left a comment
zymap
left a comment
There was a problem hiding this comment.
https://github.com/apache/bookkeeper/pull/4665/files
Here is the fix. You should check the platform first instead of changing all the platform to that.
Contributor
Author
|
Close this PR as the issue has already been resolved by https://github.com/apache/bookkeeper/pull/4665/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Many PRs cannot be merged because of this test failure. Even after rerunning multiple times, they still fail due to the same error.
This doesn't seem to be a flaky test, but rather a blocking test that always fails！
Error: OUTPUT>native-io-jni/cpp/native_io_jni.c:168:21: error: passing argument 1 of 'fflush' makes pointer from integer without a cast [-Wint-conversion]https://github.com/apache/bookkeeper/actions/runs/18648851159/job/53162582666?pr=4674
https://github.com/apache/bookkeeper/actions/runs/18552216345/job/53161739919?pr=4673
https://github.com/apache/bookkeeper/actions/runs/18526985175/job/52800716265?pr=4672
https://github.com/apache/bookkeeper/actions/runs/18526392532/job/52798756494?pr=4653
Changes
fflush requires a FILE*, but we're passing an int file descriptor.
On Windows, the correct equivalent is _commit(fd), which takes an int fd.
So, change the mapping of fsync from fflush to _commit.