Skip to content

Bring back the old public method name which removed from #4640 #4682

Merged
zymap merged 1 commit intoapache:masterfrom
zymap:yong/fix-method-signature
Nov 24, 2025
Merged

Bring back the old public method name which removed from #4640 #4682
zymap merged 1 commit intoapache:masterfrom
zymap:yong/fix-method-signature

Conversation

@zymap
Copy link
Member

@zymap zymap commented Nov 13, 2025

Descriptions of the changes in this PR:

Fix #xyz

Main Issue: #xyz

BP: #xyz

Motivation

#4640 changed the public method name, which breaks the downstream API calls. Change it back to avoid the break.

Changes

(Describe: what changes you have made)


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@zymap zymap changed the title Bring back the old public method name Bring back the old public method name which removed from #4640 Nov 13, 2025
@hangc0276 hangc0276 closed this Nov 13, 2025
@hangc0276 hangc0276 reopened this Nov 13, 2025
@zymap zymap self-assigned this Nov 24, 2025
@zymap zymap added this to the 4.18.0 milestone Nov 24, 2025
@zymap zymap merged commit 1a509e4 into apache:master Nov 24, 2025
87 of 102 checks passed
@zymap zymap deleted the yong/fix-method-signature branch November 24, 2025 03:32
lhotari pushed a commit that referenced this pull request Nov 28, 2025
lhotari pushed a commit that referenced this pull request Nov 28, 2025
priyanshu-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Dec 2, 2025
(cherry picked from commit 1a509e4)
(cherry picked from commit c23a28f)
srinath-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Dec 4, 2025
(cherry picked from commit 1a509e4)
(cherry picked from commit c23a28f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants