[Fix] Replace Java record with nested class in ConcurrentLongHashMap (branch-4.17)#4778
Merged
merlimat merged 1 commit intoMay 7, 2026
Conversation
…pache#4777) branch-4.17 targets Java 8, but apache#4771 introduced a Java `record` declaration in ConcurrentLongHashMap.Section, which requires Java 16+. This breaks the build with: ConcurrentLongHashMap.java:[320,29] ';' expected ConcurrentLongHashMap.java:[320,32] illegal start of type Replace the record with an equivalent `static final` nested class exposing keys(), values() and capacity() accessors so the existing call sites are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4777
Summary
branch-4.17targets Java 8 but #4771 introduced a Javarecorddeclaration inConcurrentLongHashMap.Section, which requires Java 16+. This broke the build with:This change replaces the record with an equivalent
static finalnested class that exposeskeys(),values()andcapacity()accessors, leaving the existing call sites unchanged.masteris not affected because it already targets Java 17.