Skip to content

Issue 515: Run bookies using hostIP instead of containerIP in k8s#516

Closed
sijie wants to merge 3 commits into
apache:masterfrom
sijie:run_bookie_using_hostport_bk
Closed

Issue 515: Run bookies using hostIP instead of containerIP in k8s#516
sijie wants to merge 3 commits into
apache:masterfrom
sijie:run_bookie_using_hostport_bk

Conversation

@sijie
Copy link
Copy Markdown
Member

@sijie sijie commented Sep 18, 2017

Descriptions of the changes in this PR:

  • use status.hostIP rather than status.containerIP. so the identifier (ip) of a bookie pod will not be changed after it is restarted.
  • use adverstiseAddress to advertise hostip as the ip of a bookie pod
  • change it to use hierarchical ledger manager

@sijie sijie added this to the 4.6.0 milestone Sep 18, 2017
@sijie sijie self-assigned this Sep 18, 2017
@sijie sijie requested review from jiazhai and merlimat September 18, 2017 22:17
merlimat
merlimat approved these changes Sep 18, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asfgit
Copy link
Copy Markdown

asfgit commented Sep 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/bookkeeper-precommit-pullrequest-docker/26/

jiazhai
jiazhai approved these changes Sep 18, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks for the fix.

@jiazhai jiazhai closed this in eba4d6e Sep 18, 2017
@sijie sijie deleted the run_bookie_using_hostport_bk branch July 16, 2018 02:50
athanatos pushed a commit to athanatos/bookkeeper that referenced this pull request Jan 25, 2019
@anmolnar @phunt
ZOOKEEPER-3038: Cleanup some nitpicks in TTL implementation
6e64125 
A few nitpicks which needs to be cleaned up:

1. Rename OldEphemeralType --> EphemeralTypeEmulate353
2. Remove unused method: getTTL()
3. Remove unused import from QuorumPeer

Author: Andor Molnar <andor@cloudera.com>

Reviewers: phunt@apache.org

Closes apache#516 from anmolnar/ZOOKEEPER-3038

Change-Id: Iec537706a35863d53daa593da2b01f6e523ef466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

@jiazhai jiazhai jiazhai approved these changes

Assignees

@sijie sijie

Labels

area/docker release/4.6.0 type/bug

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sijie @asfgit @merlimat @jiazhai