Issue 879: TestTLS fails when project path contains spaces#880
Closed
sijie wants to merge 5 commits intoapache:masterfrom
Closed
Issue 879: TestTLS fails when project path contains spaces#880sijie wants to merge 5 commits intoapache:masterfrom
sijie wants to merge 5 commits intoapache:masterfrom
Conversation
Member
Author
ArvinDevel
pushed a commit
to ArvinDevel/bookkeeper
that referenced
this pull request
Dec 19, 2017
Descriptions of the changes in this PR: Use `URI` rather than `URL`, so it won't use url-encoded path as the file path. Author: Sijie Guo <sijie@apache.org> Reviewers: Yiming Zang <yzang2016@gmail.com>, Enrico Olivelli <eolivelli@gmail.com> This closes apache#880 from sijie/relative_path, closes apache#879
This was referenced Jan 5, 2018
sijie
added a commit
that referenced
this pull request
Jan 7, 2018
Descriptions of the changes in this PR: *Problem* When using a matrix job to define a CI job running on both java 9 and java 8, the workspace file path will be added with "jdk name" (e.g. "JDK 1.8 latest" and "JDK 9 latest"). This will cause file paths contain spaces, and fail the builds. for example, #879 #880 is one of the examples. #937 can't pass ci because g++ fails when the file path contains spaces. *Solution* Splitting the matrix job into two separate jobs suffixed with "java8" and "java9", so it won't contains any space in workspace. Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #953 from sijie/separate_jdk_cis, closes #952
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Use
URIrather thanURL, so it won't use url-encoded path as the file path.