Skip to content

Issue 924: add description of shaded bookkeeper-server in 4.6.0 release notes#926

Closed
jiazhai wants to merge 1 commit intoapache:masterfrom
jiazhai:issue-924
Closed

Issue 924: add description of shaded bookkeeper-server in 4.6.0 release notes#926
jiazhai wants to merge 1 commit intoapache:masterfrom
jiazhai:issue-924

Conversation

@jiazhai
Copy link
Member

@jiazhai jiazhai commented Dec 28, 2017

Descriptions of the changes in this PR:

add description of shaded bookkeeper-server in 4.6.0 release notes

Master Issue: #924


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    <Issue # or BOOKKEEPER-#>: Description of pull request
    e.g. Issue 123: Description ...
    e.g. BOOKKEEPER-1234: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue # or BOOKKEEPER-#> in the title with the actual Issue/JIRA number.

- Provide yaml files to run BookKeeper on Kubernetes using both StatefulSets and DaemonSet. See [Issue-337](https://github.com/apache/bookkeeper/issues/337) and [Issue-681](https://github.com/apache/bookkeeper/issues/681)for more details.
- Provide yaml files to run BookKeeper on Kubernetes using both StatefulSets and DaemonSet. See [Issue-337](https://github.com/apache/bookkeeper/issues/337) and [Issue-681](https://github.com/apache/bookkeeper/issues/681) for more details.

- Produce shaded and unshaded bookkeeper-server, so applications can choose what jar to use. The shaded jar is classified with shaded classifier. See [Issue-466](https://github.com/apache/bookkeeper/issues/466) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In issue 466 there is no clear evidence of the new layout.
We should make it clear that we have two jars deployed on Maven Central, bookkeeper-server with and without 'shaded' classifier. The shaded one is like the one bundled with 4.5. We should state this is the upgrade guide

@sijie
Copy link
Member

sijie commented Dec 28, 2017

@jiazhai since the shaded jar is not actually working as stated in #922 . so I think you can discard this pull request, since we need a fix for shaded jar and we can include that in the release note of 4.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants