BOOKKEEPER-987 BookKeeper build is broken due to the shade plugin#94
Closed
eolivelli wants to merge 1 commit intoapache:masterfrom
Closed
BOOKKEEPER-987 BookKeeper build is broken due to the shade plugin#94eolivelli wants to merge 1 commit intoapache:masterfrom
eolivelli wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
I've seen this error too. The fix LGTM +1. |
Member
|
the change looks good to me. +1 I am going to merge the changes to bring the ci back. |
reddycharan
pushed a commit
to reddycharan/bookkeeper
that referenced
this pull request
May 21, 2018
…che#94) (@W-4808141@) bkenv.sh : Quickly kill bookies on OutOfMemoryError - Disabled heap dump on out of memory error by default. - Enabled bookie exit on out of memory error preventing slow bookie death due to repeated garbage collector runs. - Modified bookkeeper to use environment variable to enable/disable heap dump on OOME Signed-off-by: Ankit Jain <jain.a@salesforce.com> (@Rev andrey@) (@Rev kudayashankar@)
reddycharan
pushed a commit
to reddycharan/bookkeeper
that referenced
this pull request
Jul 6, 2018
…che#94) (@W-4808141@) bkenv.sh : Quickly kill bookies on OutOfMemoryError - Disabled heap dump on out of memory error by default. - Enabled bookie exit on out of memory error preventing slow bookie death due to repeated garbage collector runs. - Modified bookkeeper to use environment variable to enable/disable heap dump on OOME Signed-off-by: Ankit Jain <jain.a@salesforce.com> (@Rev andrey@) (@Rev kudayashankar@) (cherry picked from commit b90c272)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is simply an upgrade of the maven-shade-plugin to version 2.4.3