Skip to content

BOOKKEEPER-988: Add missing license header#95

Closed
sijie wants to merge 2 commits intoapache:masterfrom
sijie:sijie/fix_license_header
Closed

BOOKKEEPER-988: Add missing license header#95
sijie wants to merge 2 commits intoapache:masterfrom
sijie:sijie/fix_license_header

Conversation

@sijie
Copy link
Copy Markdown
Member

@sijie sijie commented Dec 18, 2016

No description provided.

Copy link
Copy Markdown
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

With this patch I run RAT and the build is OK
mvn clean install -DskipTests apache-rat:check

Maybe @sijie can you consider adding .gitignore to the pom.xml ?

#!/usr/bin/env bash
#
#/**
# * Copyright 2007 The Apache Software Foundation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace 2007 with 2016 or provide a license without the "year" ?

@asfgit asfgit closed this in 5486347 Dec 20, 2016
athanatos pushed a commit to athanatos/bookkeeper that referenced this pull request Jan 25, 2019
Author: fpj <fpj@apache.org>

Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>

Closes apache#95 from fpj/ZK-2622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants