Fix for: script starting Brooklyn Vagrant instance checks for non-exi…#156
Merged
tbouron merged 1 commit intoapache:masterfrom Feb 11, 2020
Merged
Fix for: script starting Brooklyn Vagrant instance checks for non-exi…#156tbouron merged 1 commit intoapache:masterfrom
tbouron merged 1 commit intoapache:masterfrom
Conversation
…sting message and ends up hangging.
tbouron
approved these changes
Feb 11, 2020
| echo "== SS\ SS | SS |SS\ SS __SS |SS | SS |SS\ SS ____|SS | SS | ==" | ||
| echo "== \SSSSSS | \SSSS |\SSSSSSS |SS | \SSSS |\SSSSSSS\ \SSSSSSS | ==" | ||
| echo "== \______/ \____/ \_______|\__| \____/ \_______| \_______| ==" | ||
| echo "============================================================================================" No newline at end of file |
Member
There was a problem hiding this comment.
That seems a bit excessive isn't it? Buy hey, it works :)
rdowner
pushed a commit
that referenced
this pull request
Feb 18, 2020
Fix for: script starting Brooklyn Vagrant instance checks for non-exi…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Brooklyn instance is started, but the Vagrant command to start it never ends because it checks for the 'Bundle STARTED ...vtext to confirm start, and that is not in there.
The script was modified to check for "Brooklyn initialisation (part two) complete" instead to confirm that Brooklyn started correctly.