Skip to content

Populate catalog from bundle bom#26

Merged
asfgit merged 1 commit intoapache:masterfrom
geomacy:populate-catalog-from-bundle-bom
Apr 15, 2016
Merged

Populate catalog from bundle bom#26
asfgit merged 1 commit intoapache:masterfrom
geomacy:populate-catalog-from-bundle-bom

Conversation

@geomacy
Copy link
Copy Markdown
Contributor

@geomacy geomacy commented Mar 24, 2016

The PR adds updates to the existing jars to add a catalog.bom file that includes the details of the various entities in each.

See apache/brooklyn-server#80 for details; this PR depends on that one and should be merged after it.


brooklyn.catalog:
version: 0.9.0
scanJavaAnnotations: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove.

@neykov
Copy link
Copy Markdown
Member

neykov commented Apr 13, 2016

Also could you squash the commits.

@geomacy geomacy force-pushed the populate-catalog-from-bundle-bom branch from 2c09645 to 9659453 Compare April 13, 2016 10:44
@geomacy
Copy link
Copy Markdown
Contributor Author

geomacy commented Apr 13, 2016

Version updated and commits squashed.

# under the License.

brooklyn.catalog:
version: 0.10.0 # BROOKLYN_VERSION
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be -SNAPSHOT, as done in brooklyn-library

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, of course. Will fix.

@geomacy geomacy force-pushed the populate-catalog-from-bundle-bom branch from 9659453 to c1ced23 Compare April 13, 2016 11:36
@geomacy
Copy link
Copy Markdown
Contributor Author

geomacy commented Apr 13, 2016

That's more like it.

@asfgit asfgit merged commit c1ced23 into apache:master Apr 15, 2016
asfgit pushed a commit that referenced this pull request Apr 15, 2016
Populate catalog from bundle bom

The PR adds updates to the existing jars to add a catalog.bom file that includes the details of the various entities in each.

See apache/brooklyn-server#80 for details; this PR depends on that one and should be merged after it.
@geomacy geomacy deleted the populate-catalog-from-bundle-bom branch April 20, 2016 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants