OSGi features cleanup#42
Merged
Merged
Conversation
Split loading in chunks by using prerequisite flag.
| </feature> | ||
|
|
||
| <feature name="brooklyn-boot" version="${project.version}" description="Bundles to start on boot"> | ||
| <feature prerequisite="true">brooklyn-with-ui</feature> |
Contributor
There was a problem hiding this comment.
When I tried to build this I get:
[ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.0.4:assembly (default-assembly) on project apache-brooklyn: Unable to build assembly: Could not find matching feature for brooklyn-with-ui -> [Help 1]
Member
Author
There was a problem hiding this comment.
Sorry about that, didn't push the latest changes. Should be all good now.
Contributor
|
Looks good to me from review point of view and AMP starts successfully. Haven't tested a large number of restarts using the script though. |
Contributor
|
successfully tested |
asfgit
pushed a commit
that referenced
this pull request
Aug 22, 2016
OSGi features cleanup Depends on apache/brooklyn-server#303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on apache/brooklyn-server#303