Merged
Conversation
Adds gitbook to packages.json so you don't have to explicitly install it. Integrates gitbook into npm to make it nice and fast to get started. `npm install` will install everything and set up gitbook; `npm run serve` and `npm run build` will run the equivalent gitbook commands. No need to worry about gitbook being on the path or being globally installed. Also a couple of other tweaks to remove some npm and gitbook warning messages.
They do not render correctly with GitBook. They are also redundant: GitBook will automatically apply it to external links.
In HTML, provide a hint that the OS selection buttons are at the top of the page. Add headers to each language section so it makes sense when rendered as PDF.
Must not use hyphens in gitbook variable names
…herefore displayed in the generated page. Also fix the titles level so that all sections have the same structure, starting with h2
m4rkmckenna
approved these changes
Oct 25, 2017
Member
Author
|
Thanks @m4rkmckenna ! However, can you hold off a wee bit more? I just realised that while internal relative links are perfectly fine for the docs, it might cause issues for downstream projects therefore I would like to update those links to use the same trick we did before, i.e. I'll ping you once it's done |
Member
Author
|
@m4rkmckenna Done, should be good to go now |
Member
|
Thanks @tbouron merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per as the discussion on the ML: https://lists.apache.org/thread.html/760a3e2fdefaff8d8ac4ea3f98a45060fbaa0d886fa57c8f44e4742e@%3Cdev.brooklyn.apache.org%3E