BROOKLYN-588: add to troubleshooting for curl failure #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouron
reviewed
Jun 4, 2018
| For example, [security groups for EC2-classic] | ||
| (http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html#ec2-classic-security-groups) | ||
| For example, | ||
| [security groups for EC2-classic](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html) |
Member
There was a problem hiding this comment.
Why did you removed the anchor here? It is still valid.
Having said that, the section doesn't seem to have specificities to firewalls. So the title probably need to change to security groups for EC2, or be dropped all together
Contributor
Author
There was a problem hiding this comment.
Good spot. I removed the anchor because it's not just ec2-classic that is used in Brooklyn (one can point it at VPC security groups). Therefore I've changed the link text to 'security groups for AWS EC2'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/BROOKLYN-588