Skip to content

Clean up docs#266

Merged
asfgit merged 9 commits intoapache:masterfrom
kemitix:review-docs-for-530-rc3
Aug 30, 2018
Merged

Clean up docs#266
asfgit merged 9 commits intoapache:masterfrom
kemitix:review-docs-for-530-rc3

Conversation

@kemitix
Copy link
Contributor

@kemitix kemitix commented Aug 24, 2018

  • fix a few typos
  • extract some code blocks to example_yaml
  • fix loading bash script as tar.gz from url to ensure it is executable
  • fix hi netcat example to close the connection at end of file
  • wrap jdbc string format in quotes

/tmp/brooklyn-...-launching_VanillaSoftwareProce.sh:
    line 9: ./start.sh: Permission denied
From the nc(1) man page:

     -N shutdown(2) the network socket after EOF on the input. Some servers
        require this to finish their work.

Ubuntu would appear to be one such server.
Ampersand (&) in format wasn't being parsed properly.
Added a name for the deployed application.
Copy link
Member

@tbouron tbouron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kemitix !
Just got one small comment

The version of netcat on MacOS doesn't support, or need, the `-N` parameter.
@asfgit asfgit merged commit fbc27ca into apache:master Aug 30, 2018
asfgit pushed a commit that referenced this pull request Aug 30, 2018
@kemitix kemitix deleted the review-docs-for-530-rc3 branch August 30, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants