Incorporate some feedback from Aled Sage#291
Merged
Merged
Conversation
aledsage
reviewed
Aug 28, 2019
Contributor
aledsage
left a comment
aledsage
left a comment
There was a problem hiding this comment.
Looks good, thanks @infrastation
Only one minor comment.
| without the developer having to think through the order, but it can take some getting used to. | ||
| Be careful not to request config information until really necessary (or to use non-blocking "raw" mechanisms), | ||
| and in complicated situations be ready to attend to circular dependencies. | ||
| Trying to resolve a circular dependency leads to a deadlock of respective activity, and Brooklyn currently does not detect deadlocks. |
Contributor
There was a problem hiding this comment.
I'd word this less negatively.
Trying to resolve a circular dependency leads to a deadlock in those activities. The presence of such deadlocks can be seen by viewing the web-console's 'activities' tab of the (hung) entities - it will show what the executing activities are waiting for. Automated detection/alerting of deadlocks is currently not supported in Brooklyn.
* configuration-sensor-effectors.md: reword for clarity * lifecycle-managementcontext.md: Brooklyn does not support that feature * execution.md: idem * dependent-configuration.md: acknowledge the potential for deadlocks * application-parent-membership.md: expand the example
Contributor
Author
|
@aledsage, updated the text as you suggested. |
Contributor
|
Thx - merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.