Skip to content

Add Apache ActiveMQ Artemis catalog item#134

Merged
tbouron merged 1 commit intoapache:masterfrom
bostko:add-artemis
Nov 27, 2019
Merged

Add Apache ActiveMQ Artemis catalog item#134
tbouron merged 1 commit intoapache:masterfrom
bostko:add-artemis

Conversation

@bostko
Copy link
Contributor

@bostko bostko commented Oct 9, 2017

Catalog item is visible in Apache Brooklyn karaf build
BROOKLYN-541

type: org.apache.brooklyn.entity.software.base.VanillaSoftwareProcess
name: ActiveMQ Artemis
itemType: entity
description: Apache ActiveMQ Artemis has a proven non blocking architecture. It delivers outstanding performance. JMS 2.0 and 1.1 support.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth a note that it is a message broker, maybe

"Apache ActiveMQ Artemis is an open source message broker and has a proven non blocking architecture. It delivers outstanding performance. JMS 2.0 and 1.1 support."

@michaelandrepearce
Copy link

@bostko thanks for this :)

description: ActiveMQ is an open source message broker which fully implements the Java Message Service 1.1 (JMS)
- id: org.apache.brooklyn.entity.messaging.activemq-artemis
version: "1.0.0-SNAPSHOT" # BROOKLYN_VERSION
item:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be good to add an icon url

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on @michaelandrepearce's suggestion

- id: org.apache.brooklyn.entity.messaging.activemq-artemis
version: "1.0.0-SNAPSHOT" # BROOKLYN_VERSION
item:
type: org.apache.brooklyn.entity.software.base.VanillaSoftwareProcess

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im very new to brooklyn, whats the difference between this and a concrete type? It be good to have a concrete type? like the others?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelandrepearce It's good to have concrete type only for very complex blueprint. Otherwise, we recommend doing as much as possible in YAML as it is very portable and easy to read and develop.

@tbouron
Copy link
Member

tbouron commented Dec 21, 2017

@bostko Have you seen @michaelandrepearce's suggestions. Do you think you can address them?

@bostko bostko force-pushed the add-artemis branch 4 times, most recently from e006a54 to f02a8f7 Compare December 21, 2017 21:55
@bostko
Copy link
Contributor Author

bostko commented Dec 21, 2017

Thanks for the reminder @tbouron . Addressed comments.
Feel free to edit my PR if you have more comments.

@tbouron
Copy link
Member

tbouron commented Feb 15, 2018

@bostko Sorry for the very late reply. It still miss an icon (see #134 (comment)). After that, it should be good to go

Catalog item is visible in Apache Brooklyn karaf build
BROOKLYN-541
@nakomis
Copy link
Contributor

nakomis commented Nov 27, 2019

@tbouron Can you take a look at this please to check it's still valid and merge if you're now happy with it

@asf-ci
Copy link

asf-ci commented Nov 27, 2019

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Nov 27, 2019

Can one of the admins verify this patch?

@tbouron
Copy link
Member

tbouron commented Nov 27, 2019

Thanks for the nudge @nakomis. LGTM, merging

@tbouron tbouron merged commit c7b9aa6 into apache:master Nov 27, 2019
@bostko bostko deleted the add-artemis branch November 27, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants