Merged
Conversation
tbouron
approved these changes
Nov 1, 2017
Member
tbouron
left a comment
tbouron
left a comment
There was a problem hiding this comment.
Good catch @Graeme-Miller!
This one is on me, I completely forgot about the new brooklyn-library-catalog artifact, thanks 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When building Brooklyn karaf, brooklyn-library-catalog is not included in the system folder. This means that on startup Karaf goes to a remote repository (sonatype) or local maven cache to retrieve it. A separate PR will be created to stop Brooklyn from using remote repos.
Fix
Update the feature brooklyn-library-all such that it contains a reference to the brooklyn-library-catalog bundle. This means that when building Brooklyn, brooklyn-library-catalog is included in the systems folder.