Conversation
Jenkinsfile
Outdated
| ]) | ||
| } | ||
|
|
||
| // TODO: Build full brooklyn project |
There was a problem hiding this comment.
Does this need to be in here? Surely the trigger will be built into the top level brooklyn build job? I'd have thought it's not up to upstream jobs like this to decide what downstream jobs need to be triggered, rather it's up to any number of downstreams to see this job succeeding and then decide to rebuild themselves?
There was a problem hiding this comment.
Ah you are right @geomacy I can use pipelineTriggers into the downstream project. I'll remove the TODO then
| catchError { | ||
| def environmentDockerImage | ||
|
|
||
| def dockerTag = env.BUILD_TAG.replace('%2F', '-') |
There was a problem hiding this comment.
why's this needed? The tags have the form jenkins-brooklyn-library-master-docker-179
There was a problem hiding this comment.
@geomacy this is needed because if the job name contains a / (which is possible as the name will be the actual branch to build) it will be replaced by the URL escaped version, i.e. %2F. However, docker tag accepts only alphanumerical characters + ., - and _
4 participants
This capture the current Jenkins configuration, so that is repeatable and documented.