Don't force binding to 127.0.0.1 when using AnyoneSecurityProvider#101
Merged
asfgit merged 1 commit intoapache:masterfrom May 13, 2016
Merged
Don't force binding to 127.0.0.1 when using AnyoneSecurityProvider#101asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
@neykov I'm seeing it bind to all interfaces as expected now, but we still see the loopback logged to the console. I can't recall seeing it log that its bound to all interfaces in the past but it might be nice to show that for correctness. |
Member
Author
|
@johnmccabe It's meant as a simple copy&paste aid (or click for terminals that support it). So better to use a real address. |
Keeps backwards compatibility - using AnyoneSecurityProvider wouldn't force brooklyn server to bind to loopback only, but then changed to being treated same as noSecurityProvider. Revert to initial behaviour.
neykov
force-pushed
the
fix/skip-security
branch
from
fcbc941 to
64bb70d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps backwards compatibility - using AnyoneSecurityProvider wouldn't force brooklyn server to bind to loopback only, but then changed to being treated same as noSecurityProvider. Revert to initial behaviour.
/cc @johnmccabe