add distinction between "application" and "template" in catalog itemType #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents delays while it tries to resolve things which aren't immediately available
…hich don't set template tag
ahgittin
force-pushed
the
catalog-itemtype-application
branch
from
4100f9b to
5dbf70d
Compare
Contributor
Author
|
also fixes issue with resolving details for things which aren't immediately available, in first commit here |
asfgit
pushed a commit
that referenced
this pull request
Nov 15, 2018
ahgittin
added a commit
to ahgittin/brooklyn-ui
that referenced
this pull request
Nov 16, 2018
in line with apache/brooklyn-server#1015 also when using a template the metadata is not populated as the intention is probably not to overwrite, unless the user selects to save it as a template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously
templatewas the only way to class something as an application, and it did both:Applicationcatalog_templatetag so it looks llke a templatethis adds support for an
itemType: applicationwhich only does the first of these